Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FSharp.Compiler.Service to 43.7.200 #796

Merged
merged 7 commits into from
Mar 29, 2023
Merged

Update FSharp.Compiler.Service to 43.7.200 #796

merged 7 commits into from
Mar 29, 2023

Conversation

nojaf
Copy link
Collaborator

@nojaf nojaf commented Feb 16, 2023

A naive attempt to update FCS.

@nojaf
Copy link
Collaborator Author

nojaf commented Feb 16, 2023

A couple of tests seem to fail. Altough not if you run them in isolation.

@nojaf nojaf mentioned this pull request Feb 24, 2023
Closed
@nojaf
Copy link
Collaborator Author

nojaf commented Feb 26, 2023

For some reason the evaluation of "it" stops working after a while:
image

@nojaf
Copy link
Collaborator Author

nojaf commented Mar 28, 2023

This would resolve #799 as well.

@nhirschey
Copy link
Collaborator

Off the top of your head, do you know if it will also solve #551?

@nojaf
Copy link
Collaborator Author

nojaf commented Mar 28, 2023

I tried this locally and this does appear to work for me.

@nojaf nojaf requested a review from baronfel March 29, 2023 09:54
@nojaf
Copy link
Collaborator Author

nojaf commented Mar 29, 2023

@baronfel I think this is good to go. Could you skim through it, please?

@nojaf nojaf linked an issue Mar 29, 2023 that may be closed by this pull request
Consider targetting .NET 6 as well #799
Closed
@nojaf nojaf mentioned this pull request Mar 29, 2023
Open
baronfel
baronfel approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is without a doubt the most beautiful, efficient, and effective code I have ever seen.

@nojaf nojaf merged commit cf55560 into fsprojects:main Mar 29, 2023
@nojaf nojaf mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider targetting .NET 6 as well
3 participants
@nojaf @nhirschey @baronfel